[01.102.110] Welders don't pull components to repair

Ship/station welders don't pull components from the conveyor system when trying to repair damaged blocks.

A minimal demonstration: https://drive.google.com/file/d/0Bys6k7VMCRfUaWg5QVFyeU95N00/view (the download button is at the top). To reproduce:
1. Load up the linked world.
2. See that the armor wall is missing components.
3. The welder doesn't fully repair it until you move the steel plates from the container to the welder manually.

This is probably the underlying cause for https://forum.keenswh.com/threads/1-...d-turrets-with-ship-and-base-welders.7361896/

 

[01.102.010 64-bit][SP][Survival]

Confirmed when repairing turrets, conveyors, conveyor tubes.

Not a show-stopper, but irritating in the long run (and this bug is old).
Perhaps raise the bug priority one step for this one.

 

I keep seeing the welders working on some blocks but not others of even the same type. For example, the welder repairs another welder on one side, but won't repair the welder on the other side (same distance).


-Morloc

 

In that other thing you linked, it looks like there would have to be small tubes somewhere between the welders and any containers on that ship, which would prevent certain components from passing through. The conveyor at the back only has small ports pointing at the center of the ship and it looks like the cockpit is obstructing the large ports to its left, right, and front. I might be wrong.

 

This could indeed have been a cause, but the problem exists without small tubes.

In my case:
Welder - Conveyor - Medium container
All blocks are directly connected by the 'large' connection points.

 

I remember having this problem in 1.101 a few times. I was able to get around it by grinding the blocks a bit first and then the welding worked fine. Both ship grinders or my hand grinder worked.

 

Sounds like a good work around. Will try it. Thanx

 

There's absolutely something weird about welders. It was just that particular instance that I was skeptical about. They have actually been giving me trouble as well, but under different circumstances.

 

Mine is basic light armor cubes. Working on a projection and will load the connector, welders and hold of my welding ship with sheet metal and it will seem testy with some armor pieces and won't draw for them to start them building. Once they are created (IE I spacewalk and start with a single piece from my suit) there MIGHT be no problem. But sometimes I have to come at it at different angles for the welding to continue.

Now it isn't just the basic cube, but it seems the least likey block that should be buggy position wise, since it's model fits the building grid (hit box?) 100% while other pieces don't.

 

Ran into this same problem last nite trying to repair some damaged turrets. I took some parts with me and hand welded a portion of the turret -- filled up with scrap metal, and then the ship mounted welders worked.

Highly annoying and it makes repairing after combat a real pain.

 

I've been seeing similar issues.


-Morloc

 

Same, i remember being very frustrated thinking i ran out of component even after just picking more up. just to find out they were stuck in the medium cargo container. i fixed my issue by manually putting the components in the welder directly.

 

This bug is persistent in current build for me. Requires "boosting" with a hand welder and comp placement.

 

Encountering the same issue.

 

I'm still getting this issue on large ships in 1.129_007 Single Player - survival, Win10x64. I found that if I turn my welders on after taking damage, they only weld a tiny fraction of the damage then fail to pull more items from conveyors. If I manually put the item in the welders, it will weld just that item.

If I leave the welders running with or without a blueprint projection:

I walk up to the damaged block and weld at it with no parts in my own inventory, no change. If I shoot at the damaged block, it will keep repairing it, but only to it's current level of damage. If I grind it, once I remove the scrap or a part from the block, the welder pulls all items successfully and will finish the job. It's almost like the welders don't read the block as incomplete or maybe the scrap metal the damaged block is holding is taking up some kind of room on a list where the new components should go.

This completely negates self healing ship designs (where I found this bug) and I would venture that it makes ship printers non-functional.

 

the problem your all having is plain and simple, the block cant be repaired as there is scrap metal (damaged/destroyed components) inside the block...... simply welding wont remove those damaged components, you must do it manually... remember your welder is a one way machine. items go from it to the block, not the other way around. as the saying goes "you cant fill a cup that is allready full" hope this clears things up

 

When was this changed? Was it ever in the patch notes? I've been away from the game for a while, is this working as intended or just an odd bug? Also, it seems to not rebuild the part if it is completely destroyed, but the projector is on. I may have to do more testing with that.

EDIT: Checked it out some more and repairing from total destructing worked. Also, once scrap is removed and "space made available" the welders will not pull items and finish the repair. If I hold all remaining items and tap my welder to the damaged block (loading all item in, but not doing the welding time) the ship welder will finish the job.

If I turn off the ship welders, remove the scrap manually with the hand held and turn ships welders on, the ships welders will not repair the damaged block.

EDIT 2:

This is clearly a bug. If you damage a block and don't remove any scrap it can be repaired if all missing items are hand loaded in to a welder on the same grid, or another craft and the scrap vanishes. However, if the scrap isn't removed, the welders (same grid or not) won't send the pull requests it needs to fix the item.

Test - Survival Mode:

Shoot a turret until almost destroyed.

Turn on ship welder with spare parts needed in conveyor accessible cargo (welder+cargo can be either same grid or separate ship), no response, turn off ship welders.

Manually add the missing parts to the welder using the conveyor network, turn on welder.

Welder will complete the task now.

 

Problem still persists as in above edit2 in version 1_130_012. Other post suggest this might have something to do with sorters, which the ship I'm testing this with does have operating. https://forum.keenswh.com/threads/01...-conveyor-sorter-bug.7382732/#post-1286965608

EDIT: I took the sorters out and made a new blueprint from that ship, same bugs apply. It's like they fixed it on Thursday and re-broke it Friday.

 

It seems that pull requests in general don’t work reliable in survival this includes not only welders but also reloadable rocket launchers and turrets. In my experience with launchers and turrets it works for a few requests and then stops working and no longer pulls at all (you can still place manually). Sorter "drain all" also seems to be not working as often as not but when it works it ignores blacklisted items on other sorters in the way (and whitelists for that matter).
Also Assemblers don’t seem cooperate if there is more than one additional assembler in cooperative mode.

Edit: Assembler, refinery and oxygen generator ingot, ore and ice pull seem to be working fine though.